Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1165693002: X87: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. port 32de677805877bbf8d697926e09c23963a27e191 (r29615) original commit message: The reason is that this information will be needed to compute the number of vector ic slots done at numbering time. BUG= Committed: https://crrev.com/6b93438d518a7bf37885005a735fe4bc69bad0ab Cr-Commit-Position: refs/heads/master@{#28715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-01 06:14:20 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-01 08:21:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165693002/1
5 years, 6 months ago (2015-06-01 08:21:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 08:45:25 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 08:45:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b93438d518a7bf37885005a735fe4bc69bad0ab
Cr-Commit-Position: refs/heads/master@{#28715}

Powered by Google App Engine
This is Rietveld 408576698