Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: public/platform/WebCredential.h

Issue 1165673005: Credential Manager: Rename 'avatarURL' to 'iconURL'. (1/3 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-local
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/exported/WebCredential.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebCredential.h
diff --git a/public/platform/WebCredential.h b/public/platform/WebCredential.h
index f40a3c159226da1d00bcfa0e8d69420d2f6b4884..7aaf128d3e6f7ccb924504b565c4749801dbdcad 100644
--- a/public/platform/WebCredential.h
+++ b/public/platform/WebCredential.h
@@ -16,7 +16,7 @@ class PlatformCredential;
class WebCredential {
public:
- BLINK_PLATFORM_EXPORT WebCredential(const WebString& id, const WebString& name, const WebURL& avatarURL);
+ BLINK_PLATFORM_EXPORT WebCredential(const WebString& id, const WebString& name, const WebURL& iconURL);
BLINK_PLATFORM_EXPORT WebCredential(const WebCredential&);
virtual ~WebCredential() { reset(); }
@@ -25,9 +25,12 @@ public:
BLINK_PLATFORM_EXPORT WebString id() const;
BLINK_PLATFORM_EXPORT WebString name() const;
- BLINK_PLATFORM_EXPORT WebURL avatarURL() const;
+ BLINK_PLATFORM_EXPORT WebURL iconURL() const;
BLINK_PLATFORM_EXPORT WebString type() const;
+ // TODO(mkwst): Drop this once Chromium is updated. https://crbug.com/494880
+ BLINK_PLATFORM_EXPORT WebURL avatarURL() const { return iconURL(); }
+
BLINK_PLATFORM_EXPORT bool isPasswordCredential() const;
BLINK_PLATFORM_EXPORT bool isFederatedCredential() const;
« no previous file with comments | « Source/platform/exported/WebCredential.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698