Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 1165673005: Credential Manager: Rename 'avatarURL' to 'iconURL'. (1/3 (Closed)

Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@remove-local
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Credential Manager: Rename 'avatarURL' to 'iconURL'. (1/3) Patch 1 (Blink): [This patch] Patch 2 (Chromium): TBD Patch 3 (Blink): TBD BUG=494880 R=vabr@chromium.org,jochen@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -43 lines) Patch
M LayoutTests/http/tests/credentialmanager/credentialscontainer-notifyfailedsignin-basics.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/credentialmanager/credentialscontainer-notifysignedin-basics.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/credentialmanager/credentialscontainer-request-basics.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/credentialmanager/Credential.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/credentialmanager/Credential.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/credentialmanager/Credential.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/credentialmanager/PlatformCredential.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/credentialmanager/PlatformCredential.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/exported/WebCredential.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebCredential.h View 2 chunks +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
Mike West
More.
5 years, 6 months ago (2015-06-01 09:53:28 UTC) #1
vabr (Chromium)
lgtm
5 years, 6 months ago (2015-06-01 10:01:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-01 13:13:12 UTC) #3
vabr (Chromium)
5 years, 3 months ago (2015-09-04 13:16:55 UTC) #4
This looks stale, so removing myself from reviewers to keep my codereview
dashboard clean. Feel free to re-add me if this is revived.

Powered by Google App Engine
This is Rietveld 408576698