Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2496)

Unified Diff: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Issue 1165673002: [Startup Tracing] Hook up TraceConfig and remove CategoryFilter & TraceOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.cc ('k') | mandoline/app/desktop/launcher_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/v8_sampling_profiler_browsertest.cc
diff --git a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
index 28b17933759faf39a2aa88d70ca761b973114054..7ebaec0fe888425b1fd5d4562fcd703f0f4f6c3c 100644
--- a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
+++ b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc
@@ -11,9 +11,8 @@
using base::DictionaryValue;
using base::ListValue;
using base::Value;
-using base::trace_event::CategoryFilter;
+using base::trace_event::TraceConfig;
using base::trace_event::TraceLog;
-using base::trace_event::TraceOptions;
using base::trace_event::TraceResultBuffer;
namespace content {
@@ -82,8 +81,8 @@ class V8SamplingProfilerTest : public RenderViewTest {
sampling_profiler_->EnableSamplingEventForTesting(code_added_events,
sample_events);
trace_log->SetEnabled(
- CategoryFilter(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile")),
- TraceLog::RECORDING_MODE, TraceOptions());
+ TraceConfig(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"), ""),
+ TraceLog::RECORDING_MODE);
base::RunLoop().RunUntilIdle();
KickV8(); // Make a call to V8 so it can invoke interrupt request
// callbacks.
@@ -122,8 +121,8 @@ class V8SamplingProfilerTest : public RenderViewTest {
TEST_F(V8SamplingProfilerTest, V8SamplingEventFired) {
sampling_profiler_->EnableSamplingEventForTesting(0, 0);
TraceLog::GetInstance()->SetEnabled(
- CategoryFilter(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile")),
- TraceLog::RECORDING_MODE, TraceOptions());
+ TraceConfig(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"), ""),
+ TraceLog::RECORDING_MODE);
base::RunLoop().RunUntilIdle();
sampling_profiler_->WaitSamplingEventForTesting();
TraceLog::GetInstance()->SetDisabled();
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.cc ('k') | mandoline/app/desktop/launcher_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698