[Startup Tracing] Hook up TraceConfig and remove CategoryFilter & TraceOptions

base/trace_event/memory_dump_manager_unittest.cc

Index: base/trace_event/memory_dump_manager_unittest.cc
diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc
index 1da9429588e14b1de200dc278a50df92e40dd945..c15748c9ab71e10d13b4850f667cc2f17e98772f 100644
--- a/base/trace_event/memory_dump_manager_unittest.cc
+++ b/base/trace_event/memory_dump_manager_unittest.cc
@@ -64,7 +64,7 @@ class MemoryDumpManagerTest : public testing::Test {
 
   void EnableTracing(const char* category) {
     TraceLog::GetInstance()->SetEnabled(
-        CategoryFilter(category), TraceLog::RECORDING_MODE, TraceOptions());
+        TraceConfig(category, ""), TraceLog::RECORDING_MODE);

[dsinclair, 2015/06/02 13:56:54]

Can we add a default value of "" to the trace config for trace options so we
don't have to pass , "" everywhere?

[Zhen Wang, 2015/06/02 16:24:41]

TraceConfig has the following two constructors

1. TraceConfig(const std::string&, const std::string&);
This is for category filter string and trace options string

2. explicit TraceConfig(const std::string&);
This is for trace config string (JSON format)

Using the default value "" for trace options will not work.


One way to solve this is to change

explicit TraceConfig(const std::string&);

to

explicit TraceConfig(scoped_ptr<base::Value> value);

where |value| is the parsed values from the JSON formatted config string. This
requires parsing the config string outside of TraceConfig class.

How do you think?

   }
 
   void DisableTracing() { TraceLog::GetInstance()->SetDisabled(); }