[Startup Tracing] Hook up TraceConfig and remove CategoryFilter & TraceOptions

content/browser/tracing/tracing_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tracing/tracing_ui.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 34 matching lines @@
        it != categorySet.end(); it++) {
     category_list.AppendString(*it);
   }
 
   base::RefCountedString* res = new base::RefCountedString();
   base::JSONWriter::Write(category_list, &res->data());
   callback.Run(res);
 }
 
 bool GetTracingOptions(const std::string& data64,
-                       base::trace_event::CategoryFilter* category_filter,
-                       base::trace_event::TraceOptions* tracing_options) {
+                       base::trace_event::TraceConfig* trace_config) {
   std::string data;
   if (!base::Base64Decode(data64, &data)) {
     LOG(ERROR) << "Options were not base64 encoded.";
     return false;
   }
 
   scoped_ptr<base::Value> optionsRaw = base::JSONReader::Read(data);
   if (!optionsRaw) {
     LOG(ERROR) << "Options were not valid JSON";
     return false;
   }
   base::DictionaryValue* options;
   if (!optionsRaw->GetAsDictionary(&options)) {
     LOG(ERROR) << "Options must be dict";
     return false;
   }
 
-  if (!category_filter) {
-    LOG(ERROR) << "category_filter can't be passed as NULL";
-    return false;
-  }
-
-  if (!tracing_options) {
-    LOG(ERROR) << "tracing_options can't be passed as NULL";
+  if (!trace_config) {
+    LOG(ERROR) << "trace_config can't be passed as NULL";
     return false;
   }
 
   bool options_ok = true;
   std::string category_filter_string;
   options_ok &= options->GetString("categoryFilter", &category_filter_string);
-  *category_filter = base::trace_event::CategoryFilter(category_filter_string);
 
   std::string record_mode;
-  options_ok &=
-      options->GetString("tracingRecordMode", &record_mode);
-  options_ok &= tracing_options->SetFromString(record_mode);
+  options_ok &= options->GetString("tracingRecordMode", &record_mode);
 
-  options_ok &= options->GetBoolean("useSystemTracing",
-                                    &tracing_options->enable_systrace);
-  options_ok &=
-      options->GetBoolean("useSampling", &tracing_options->enable_sampling);
+  *trace_config = base::trace_event::TraceConfig(category_filter_string,
+                                                 record_mode);
+
+  bool enable_systrace;
+  options_ok &= options->GetBoolean("useSystemTracing", &enable_systrace);
+  if (enable_systrace)
+    trace_config->EnableSystrace();
+
+  bool enable_sampling;
+  options_ok &= options->GetBoolean("useSampling", &enable_sampling);
+  if (enable_sampling)
+    trace_config->EnableSampling();
 
   if (!options_ok) {
     LOG(ERROR) << "Malformed options";
     return false;
   }
   return true;
 }
 
 void OnRecordingEnabledAck(const WebUIDataSource::GotDataCallback& callback);
 
 bool BeginRecording(const std::string& data64,
                     const WebUIDataSource::GotDataCallback& callback) {
-  base::trace_event::CategoryFilter category_filter("");
-  base::trace_event::TraceOptions tracing_options;
-  if (!GetTracingOptions(data64, &category_filter, &tracing_options))
+  base::trace_event::TraceConfig trace_config("", "");
+  if (!GetTracingOptions(data64, &trace_config))
     return false;
 
   return TracingController::GetInstance()->EnableRecording(
-      category_filter,
-      tracing_options,
+      trace_config,
       base::Bind(&OnRecordingEnabledAck, callback));
 }
 
 void OnRecordingEnabledAck(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void OnTraceBufferUsageResult(const WebUIDataSource::GotDataCallback& callback,
                               float percent_full,
@@ skipping 14 matching lines @@
 
   base::RefCountedString* status_base64 = new base::RefCountedString();
   base::Base64Encode(status_json, &status_base64->data());
   callback.Run(status_base64);
 }
 
 void OnMonitoringEnabledAck(const WebUIDataSource::GotDataCallback& callback);
 
 bool EnableMonitoring(const std::string& data64,
                       const WebUIDataSource::GotDataCallback& callback) {
-  base::trace_event::TraceOptions tracing_options;
-  base::trace_event::CategoryFilter category_filter("");
-  if (!GetTracingOptions(data64, &category_filter, &tracing_options))
+  base::trace_event::TraceConfig trace_config("", "");
+  if (!GetTracingOptions(data64, &trace_config))
     return false;
 
   return TracingController::GetInstance()->EnableMonitoring(
-      category_filter,
-      tracing_options,
+      trace_config,
       base::Bind(OnMonitoringEnabledAck, callback));
 }
 
 void OnMonitoringEnabledAck(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void OnMonitoringDisabled(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void GetMonitoringStatus(const WebUIDataSource::GotDataCallback& callback) {
   bool is_monitoring;
-  base::trace_event::CategoryFilter category_filter("");
-  base::trace_event::TraceOptions options;
+  base::trace_event::TraceConfig config("", "");
   TracingController::GetInstance()->GetMonitoringStatus(
-      &is_monitoring, &category_filter, &options);
+      &is_monitoring, &config);
 
   base::DictionaryValue monitoring_options;
   monitoring_options.SetBoolean("isMonitoring", is_monitoring);
-  monitoring_options.SetString("categoryFilter", category_filter.ToString());
-  monitoring_options.SetBoolean("useSystemTracing", options.enable_systrace);
+  monitoring_options.SetString("categoryFilter",
+                               config.ToCategoryFilterString());
+  monitoring_options.SetBoolean("useSystemTracing", config.IsSystraceEnabled());
   monitoring_options.SetBoolean(
       "useContinuousTracing",
-      options.record_mode == base::trace_event::RECORD_CONTINUOUSLY);
-  monitoring_options.SetBoolean("useSampling", options.enable_sampling);
+      config.GetTraceRecordMode() == base::trace_event::RECORD_CONTINUOUSLY);
+  monitoring_options.SetBoolean("useSampling", config.IsSamplingEnabled());
 
   std::string monitoring_options_json;
   base::JSONWriter::Write(monitoring_options, &monitoring_options_json);
 
   base::RefCountedString* monitoring_options_base64 =
     new base::RefCountedString();
   base::Base64Encode(monitoring_options_json,
                      &monitoring_options_base64->data());
   callback.Run(monitoring_options_base64);
 }
@@ skipping 154 matching lines @@
     web_ui()->CallJavascriptFunction("onUploadComplete",
                                      base::StringValue(feedback));
   } else {
     web_ui()->CallJavascriptFunction("onUploadError",
                                      base::StringValue(feedback));
   }
   trace_uploader_.reset();
 }
 
 }  // namespace content