Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1165653003: [es6] Stage array spread (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Stage array spread BUG=v8:3018 LOG=N Committed: https://crrev.com/e13f044d067c0662f6854c370f27bb8ce5edfac7 Cr-Commit-Position: refs/heads/master@{#28744}

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-01 16:21:36 UTC) #2
rossberg
lgtm
5 years, 6 months ago (2015-06-01 16:46:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165653003/1
5 years, 6 months ago (2015-06-01 16:46:47 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/flag-definitions.h: While running git apply --index -3 -p1; error: patch ...
5 years, 6 months ago (2015-06-01 17:19:46 UTC) #7
arv (Not doing code reviews)
git rebase
5 years, 6 months ago (2015-06-01 21:57:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165653003/20001
5 years, 6 months ago (2015-06-01 21:58:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-01 23:40:51 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 23:40:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e13f044d067c0662f6854c370f27bb8ce5edfac7
Cr-Commit-Position: refs/heads/master@{#28744}

Powered by Google App Engine
This is Rietveld 408576698