Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1165653002: cc: Move list_container_unittest.cc to cc/base/. (Closed)

Created:
5 years, 6 months ago by prashant.n
Modified:
5 years, 6 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, jbroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move list_container_unittest.cc to cc/base/. This CL takes care of moving unittest file to cc/base. The ListContainer class now gets tested using dummy classes of following types - 1. DerivedElement - This has classes derived from it. This tests classes created using ListContainer(size_t max_size_for_derived_class) constructor. 2. NonDerivedElement - This does not have any classes derived from it. This tests classes created using ListContainer() constructor. BUG=492952 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7f1fe3d77ec6dd123ab2c2f6807c72e10444ea6e Cr-Commit-Position: refs/heads/master@{#333095}

Patch Set 1 : For side-by-side comparision. #

Patch Set 2 : Moved file to cc/base. #

Patch Set 3 : Removed quad word from comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -656 lines) Patch
M cc/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
A cc/base/list_container_unittest.cc View 1 2 1 chunk +712 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M cc/quads/list_container_unittest.cc View 1 1 chunk +0 lines, -654 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
prashant.n
PTAL
5 years, 6 months ago (2015-05-30 13:42:58 UTC) #2
jbroman
Moving myself to cc as I'm probably not a good reviewer for this.
5 years, 6 months ago (2015-06-05 15:12:27 UTC) #3
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-05 17:26:26 UTC) #6
enne (OOO)
Thanks! :D
5 years, 6 months ago (2015-06-05 17:26:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165653002/40001
5 years, 6 months ago (2015-06-05 17:27:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 18:26:39 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:35:17 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7f1fe3d77ec6dd123ab2c2f6807c72e10444ea6e
Cr-Commit-Position: refs/heads/master@{#333095}

Powered by Google App Engine
This is Rietveld 408576698