Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1165623003: [Android] Allow gtests to pull app data off the device before clearing it. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
Reviewers:
perezju
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow gtests to pull app data off the device before clearing it. The test runner clears application data before each test it runs, as well as after it has run all tests. However, some suites drop useful files in the application data directory. This provides a mechanism for retrieving those files from the device. BUG=489713 Committed: https://crrev.com/5ee458982c5706abf29f456b4383aea413766cea Cr-Commit-Position: refs/heads/master@{#333768}

Patch Set 1 #

Patch Set 2 : prereview cleanup #

Patch Set 3 : fix spelling error #

Patch Set 4 : ... also fix grammar #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -8 lines) Patch
M build/android/pylib/device/device_utils.py View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 3 chunks +20 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 1 2 5 chunks +25 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_options.py View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/pylib/gtest/test_package.py View 5 chunks +15 lines, -5 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 3 chunks +8 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 chunk +4 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 2 3 4 3 chunks +15 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
jbudorick
5 years, 6 months ago (2015-05-29 21:18:32 UTC) #2
perezju
lgtm
5 years, 6 months ago (2015-06-03 11:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165623003/60001
5 years, 6 months ago (2015-06-05 16:25:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/30524)
5 years, 6 months ago (2015-06-05 18:08:51 UTC) #8
rudominer
On 2015/06/05 18:08:51, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-10 18:13:00 UTC) #9
jbudorick
On 2015/06/10 at 18:13:00, rudominer wrote: > On 2015/06/05 18:08:51, commit-bot: I haz the power ...
5 years, 6 months ago (2015-06-10 18:13:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165623003/80001
5 years, 6 months ago (2015-06-10 18:15:11 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-10 18:46:33 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:47:24 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5ee458982c5706abf29f456b4383aea413766cea
Cr-Commit-Position: refs/heads/master@{#333768}

Powered by Google App Engine
This is Rietveld 408576698