Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 1165613003: Fix issue with --print-ast and class expressions (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
rossberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix issue with --print-ast and class expressions Make sure that --print-ast works even when the class expression has no name. This also updates the printer to print the properties of the class literal. BUG=v8:4138 LOG=N R=rossberg Committed: https://crrev.com/f91c54fa0bd899da24899d4e141b422f7076d062 Cr-Commit-Position: refs/heads/master@{#28728}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed default case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -29 lines) Patch
M src/prettyprinter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/prettyprinter.cc View 1 2 chunks +43 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-05-29 21:34:23 UTC) #1
adamk
lgtm % switch https://codereview.chromium.org/1165613003/diff/1/src/prettyprinter.cc File src/prettyprinter.cc (right): https://codereview.chromium.org/1165613003/diff/1/src/prettyprinter.cc#newcode1358 src/prettyprinter.cc:1358: default: I see that this code ...
5 years, 6 months ago (2015-05-29 22:23:51 UTC) #3
arv (Not doing code reviews)
Removed default case
5 years, 6 months ago (2015-05-29 22:41:15 UTC) #4
arv (Not doing code reviews)
https://codereview.chromium.org/1165613003/diff/1/src/prettyprinter.cc File src/prettyprinter.cc (right): https://codereview.chromium.org/1165613003/diff/1/src/prettyprinter.cc#newcode1358 src/prettyprinter.cc:1358: default: On 2015/05/29 22:23:51, adamk wrote: > I see ...
5 years, 6 months ago (2015-05-29 22:42:37 UTC) #5
rossberg
lgtm
5 years, 6 months ago (2015-06-01 11:24:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165613003/20001
5 years, 6 months ago (2015-06-01 13:41:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-01 14:06:20 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 14:06:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f91c54fa0bd899da24899d4e141b422f7076d062
Cr-Commit-Position: refs/heads/master@{#28728}

Powered by Google App Engine
This is Rietveld 408576698