src/objects-inl.h - Issue 1165603002: Starting using GlobalDictionary for global objects instead of NameDictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1165603002: Starting using GlobalDictionary for global objects instead of NameDictionary. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 9a4af5317e9a0b82aeddb19ca6b139b06cad7719..dd18d5e914fac61a3eee12765ea0e048bc804fab 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -6735,9 +6735,7 @@ bool JSObject::HasIndexedInterceptor() {

NameDictionary* JSObject::property_dictionary() {

DCHECK(!HasFastProperties());

- // TODO(ishell): Uncomment, once all property_dictionary() usages for global

- // objects are replaced with global_dictionary().

- // DCHECK(!IsGlobalObject());

+ DCHECK(!IsGlobalObject());

return NameDictionary::cast(properties());

}

« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »