Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: src/objects-inl.h

Issue 1165603002: Starting using GlobalDictionary for global objects instead of NameDictionary. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6717 matching lines...) Expand 10 before | Expand all | Expand 10 after
6728 } 6728 }
6729 6729
6730 6730
6731 bool JSObject::HasIndexedInterceptor() { 6731 bool JSObject::HasIndexedInterceptor() {
6732 return map()->has_indexed_interceptor(); 6732 return map()->has_indexed_interceptor();
6733 } 6733 }
6734 6734
6735 6735
6736 NameDictionary* JSObject::property_dictionary() { 6736 NameDictionary* JSObject::property_dictionary() {
6737 DCHECK(!HasFastProperties()); 6737 DCHECK(!HasFastProperties());
6738 // TODO(ishell): Uncomment, once all property_dictionary() usages for global 6738 DCHECK(!IsGlobalObject());
6739 // objects are replaced with global_dictionary().
6740 // DCHECK(!IsGlobalObject());
6741 return NameDictionary::cast(properties()); 6739 return NameDictionary::cast(properties());
6742 } 6740 }
6743 6741
6744 6742
6745 GlobalDictionary* JSObject::global_dictionary() { 6743 GlobalDictionary* JSObject::global_dictionary() {
6746 DCHECK(!HasFastProperties()); 6744 DCHECK(!HasFastProperties());
6747 DCHECK(IsGlobalObject()); 6745 DCHECK(IsGlobalObject());
6748 return GlobalDictionary::cast(properties()); 6746 return GlobalDictionary::cast(properties());
6749 } 6747 }
6750 6748
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
7655 #undef READ_SHORT_FIELD 7653 #undef READ_SHORT_FIELD
7656 #undef WRITE_SHORT_FIELD 7654 #undef WRITE_SHORT_FIELD
7657 #undef READ_BYTE_FIELD 7655 #undef READ_BYTE_FIELD
7658 #undef WRITE_BYTE_FIELD 7656 #undef WRITE_BYTE_FIELD
7659 #undef NOBARRIER_READ_BYTE_FIELD 7657 #undef NOBARRIER_READ_BYTE_FIELD
7660 #undef NOBARRIER_WRITE_BYTE_FIELD 7658 #undef NOBARRIER_WRITE_BYTE_FIELD
7661 7659
7662 } } // namespace v8::internal 7660 } } // namespace v8::internal
7663 7661
7664 #endif // V8_OBJECTS_INL_H_ 7662 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698