Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1165603002: Starting using GlobalDictionary for global objects instead of NameDictionary. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Starting using GlobalDictionary for global objects instead of NameDictionary. Committed: https://crrev.com/144be2c4612fc2886b99dbf3f9661658dda52fec Cr-Commit-Position: refs/heads/master@{#28737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -91 lines) Patch
M src/bootstrapper.cc View 2 chunks +25 lines, -4 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +21 lines, -5 lines 0 comments Download
M src/lookup.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +9 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 17 chunks +102 lines, -51 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL, step 2
5 years, 6 months ago (2015-05-29 19:24:01 UTC) #2
Igor Sheludko
PTAL, step 2
5 years, 6 months ago (2015-06-01 14:07:48 UTC) #4
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-01 15:07:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165603002/1
5 years, 6 months ago (2015-06-01 15:58:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 16:25:12 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:25:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/144be2c4612fc2886b99dbf3f9661658dda52fec
Cr-Commit-Position: refs/heads/master@{#28737}

Powered by Google App Engine
This is Rietveld 408576698