Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tests/PixelRefTest.cpp

Issue 1165583005: add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.or… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkPixelRef.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /*
2 * Copyright 2015 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
1 #include "Test.h" 8 #include "Test.h"
2 9
3 #include "SkMallocPixelRef.h" 10 #include "SkMallocPixelRef.h"
4 #include "SkPixelRef.h" 11 #include "SkPixelRef.h"
5 12
13 static void test_install(skiatest::Reporter* reporter) {
14 SkImageInfo info = SkImageInfo::MakeN32Premul(0, 0);
15 SkBitmap bm;
16 // make sure we don't assert on an empty install
17 bm.installPixels(info, NULL, 0);
18 }
19
6 class TestListener : public SkPixelRef::GenIDChangeListener { 20 class TestListener : public SkPixelRef::GenIDChangeListener {
7 public: 21 public:
8 explicit TestListener(int* ptr) : fPtr(ptr) {} 22 explicit TestListener(int* ptr) : fPtr(ptr) {}
9 void onChange() override { (*fPtr)++; } 23 void onChange() override { (*fPtr)++; }
10 private: 24 private:
11 int* fPtr; 25 int* fPtr;
12 }; 26 };
13 27
14 DEF_TEST(PixelRef_GenIDChange, r) { 28 DEF_TEST(PixelRef_GenIDChange, r) {
15 SkImageInfo info = SkImageInfo::MakeN32Premul(10, 10); 29 SkImageInfo info = SkImageInfo::MakeN32Premul(10, 10);
(...skipping 20 matching lines...) Expand all
36 // Force the generation ID to be recalculated, then add a listener. 50 // Force the generation ID to be recalculated, then add a listener.
37 REPORTER_ASSERT(r, 0 != pixelRef->getGenerationID()); 51 REPORTER_ASSERT(r, 0 != pixelRef->getGenerationID());
38 pixelRef->addGenIDChangeListener(SkNEW_ARGS(TestListener, (&count))); 52 pixelRef->addGenIDChangeListener(SkNEW_ARGS(TestListener, (&count)));
39 pixelRef->notifyPixelsChanged(); 53 pixelRef->notifyPixelsChanged();
40 REPORTER_ASSERT(r, 1 == count); 54 REPORTER_ASSERT(r, 1 == count);
41 55
42 // Quick check that NULL is safe. 56 // Quick check that NULL is safe.
43 REPORTER_ASSERT(r, 0 != pixelRef->getGenerationID()); 57 REPORTER_ASSERT(r, 0 != pixelRef->getGenerationID());
44 pixelRef->addGenIDChangeListener(NULL); 58 pixelRef->addGenIDChangeListener(NULL);
45 pixelRef->notifyPixelsChanged(); 59 pixelRef->notifyPixelsChanged();
60
61 test_install(r);
46 } 62 }
OLDNEW
« no previous file with comments | « src/core/SkPixelRef.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698