Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1165583005: add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.or… (Closed)

Created:
5 years, 6 months ago by reed2
Modified:
5 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add asserts around results from requestLock (patchset #3 id:40001 of https://codereview.chromium.org/1155403003/)" This reverts commit 3953d360417655b8000df0951699121383db45c3. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/6980f5a96455c8062403c995a64b654a0e9a1319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -28 lines) Patch
M include/core/SkPixelRef.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 5 chunks +42 lines, -26 lines 0 comments Download
M tests/PixelRefTest.cpp View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165583005/1
5 years, 6 months ago (2015-05-29 22:28:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 22:42:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165583005/1
5 years, 6 months ago (2015-05-29 22:46:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6980f5a96455c8062403c995a64b654a0e9a1319
5 years, 6 months ago (2015-05-29 22:46:41 UTC) #7
reed2
5 years, 6 months ago (2015-05-30 01:35:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1151573009/ by reed@chromium.org.

The reason for reverting is: failure in cc_unittests (need to diagnose)

@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSo...
(run #1):@@@
@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSo...
RUN      ]
ResourceProviderTests/ResourceProviderTest.TransferInvalidSoftware/1@@@
@@@STEP_LOG_LINE@ResourceProviderTests_ResourceProviderTest.TransferInvalidSoftware_1@[17114:17114:0529/180822:15336467671:INFO:SkPixelRef.cpp(168)]
../../third_party/skia/src/core/SkPixelRef.cpp:168: failed assertion "pixels"@@@
.

Powered by Google App Engine
This is Rietveld 408576698