Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1165563003: Rework/update toolchain script for vs2015 (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Rework/update toolchain script for vs2015 This is the other side of https://codereview.chromium.org/1163723003/ The changes here are to remove the use of 'vs2013_files' and 'win8sdk' (as those will be different numbers soon enough) but still maintain behaviour for the old "style" while in transition. Secondarily, to remove the dependence of these two scripts on 'toolchain2013.py' as most of the script is now unused. R=dpranke@chromium.org BUG=440500, 492774 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295485

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : abspath #

Patch Set 7 : . #

Patch Set 8 : add missing ucrt files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -31 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 2 3 4 5 6 5 chunks +72 lines, -10 lines 0 comments Download
M win_toolchain/package_from_installed.py View 1 2 3 4 5 6 7 6 chunks +112 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
scottmg
5 years, 6 months ago (2015-06-01 21:44:58 UTC) #1
Dirk Pranke
should you be deleting toolchain2013.py in this?
5 years, 6 months ago (2015-06-01 22:33:48 UTC) #2
scottmg
On 2015/06/01 22:33:48, Dirk Pranke wrote: > should you be deleting toolchain2013.py in this? Mostly. ...
5 years, 6 months ago (2015-06-01 22:38:33 UTC) #3
Dirk Pranke
On 2015/06/01 22:38:33, scottmg wrote: > On 2015/06/01 22:33:48, Dirk Pranke wrote: > > should ...
5 years, 6 months ago (2015-06-01 22:44:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165563003/120001
5 years, 6 months ago (2015-06-01 22:50:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-01 22:53:24 UTC) #8
scottmg
(I fiddled a little more with the file list, was missing some files for 2015)
5 years, 6 months ago (2015-06-01 23:39:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165563003/140001
5 years, 6 months ago (2015-06-02 02:51:51 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 02:54:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295485

Powered by Google App Engine
This is Rietveld 408576698