Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1165553003: Fine tuning glGetInternalformativ. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index f64e6cf2f554c8bba5472697cc18243f9284a7f2..ab60f0d314fc3d9e5cc95a72dc38a4af636cba10 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -2725,8 +2725,12 @@ _FUNCTION_INFO = {
'unsafe': True
},
'GetInternalformativ': {
- 'type': 'GETn',
+ 'type': 'Custom',
+ 'data_transfer_methods': ['shm'],
'result': ['SizedResult<GLint>'],
+ 'cmd_args':
+ 'GLenumRenderBufferTarget target, GLenumRenderBufferFormat format, '
+ 'GLenumInternalFormatParameter pname, GLint* params',
'unsafe': True,
},
'GetMaxValueInBufferCHROMIUM': {
@@ -6376,11 +6380,9 @@ class GETnHandler(TypeHandler):
}
"""
else:
- code = """ GLenum error = glGetError();
+ code = """ GLenum error = LOCAL_PEEK_GL_ERROR("%(func_name)s");
if (error == GL_NO_ERROR) {
result->SetNumResults(num_values);
- } else {
- LOCAL_SET_GL_ERROR(error, "%(func_name)s", "");
}
return error::kNoError;
}
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698