Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1165513004: Chromecast: adds MessageType to BrowserCdmCast::OnSessionMessage API. (Closed)

Created:
5 years, 6 months ago by gunsch
Modified:
5 years, 6 months ago
Reviewers:
halliwell, alokp
CC:
chromium-reviews, eme-reviews_chromium.org, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds MessageType to BrowserCdmCast::OnSessionMessage API. R=halliwell@chromium.org,alokp@chromium.org BUG=internal b/18580106 Committed: https://crrev.com/d8d033690bc70ab746983db5a8e540aa116dc5ae Cr-Commit-Position: refs/heads/master@{#332241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chromecast/media/cdm/browser_cdm_cast.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 6 months ago (2015-05-30 00:34:43 UTC) #1
gunsch
On 2015/05/30 00:34:43, gunsch wrote: Luke to review, Alok for committer stamp
5 years, 6 months ago (2015-05-30 00:36:00 UTC) #2
halliwell
On 2015/05/30 00:36:00, gunsch wrote: > On 2015/05/30 00:34:43, gunsch wrote: > > Luke to ...
5 years, 6 months ago (2015-05-30 01:20:52 UTC) #3
alokp
lgtm
5 years, 6 months ago (2015-05-30 04:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165513004/1
5 years, 6 months ago (2015-06-01 18:51:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 19:32:42 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 19:33:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8d033690bc70ab746983db5a8e540aa116dc5ae
Cr-Commit-Position: refs/heads/master@{#332241}

Powered by Google App Engine
This is Rietveld 408576698