Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1165493003: Cap color index values (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cap color index values In the provided example the color table has 10 entries but some of the pixels in the bitmap overflow. This CL goes through the pixel values and caps them to the max index. An alternate approach would be to just have the color table always have 256 entries but zero out the unused ones. BUG=492265 Committed: https://skia.googlesource.com/skia/+/28937843f49b3015e9f4c04e04eb2604c3f873cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/core/SkBitmap.cpp View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 6 months ago (2015-06-05 15:43:39 UTC) #2
reed1
lgtm
5 years, 6 months ago (2015-06-08 13:14:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165493003/1
5 years, 6 months ago (2015-06-08 13:19:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 13:25:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165493003/1
5 years, 6 months ago (2015-06-08 14:10:22 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 14:10:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/28937843f49b3015e9f4c04e04eb2604c3f873cf

Powered by Google App Engine
This is Rietveld 408576698