Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart
diff --git a/sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart b/sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart
deleted file mode 100644
index b192b0599f93daf418628e53cceb0aade3e79e71..0000000000000000000000000000000000000000
--- a/sdk/lib/_internal/pub/lib/src/validator/sdk_constraint.dart
+++ /dev/null
@@ -1,30 +0,0 @@
-// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library pub.validator.sdk_constraint;
-
-import 'dart:async';
-
-import '../entrypoint.dart';
-import '../validator.dart';
-
-/// A validator that validates that a package's SDK constraint doesn't use the
-/// "^" syntax.
-class SdkConstraintValidator extends Validator {
- SdkConstraintValidator(Entrypoint entrypoint)
- : super(entrypoint);
-
- Future validate() async {
- var constraint = entrypoint.root.pubspec.environment.sdkVersion;
- if (!constraint.toString().startsWith("^")) return;
-
- errors.add(
- "^ version constraints aren't allowed for SDK constraints since "
- "older versions of pub don't support them.\n"
- "Expand it manually instead:\n"
- "\n"
- "environment:\n"
- " sdk: \">=${constraint.min} <${constraint.max}\"");
- }
-}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator/pubspec_field.dart ('k') | sdk/lib/_internal/pub/lib/src/validator/size.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698