sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart - Issue 1165473002: Start pulling pub from its own repo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart

Issue 1165473002: Start pulling pub from its own repo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Code review changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.

4

5 import 'dart:async';

6 import 'dart:convert';

7

8 import 'package:http/http.dart' as http;

9 import 'package:http/testing.dart';

10 import 'package:path/path.dart' as path;

11 import 'package:scheduled_test/scheduled_test.dart';

12

13 import '../../lib/src/entrypoint.dart';

14 import '../../lib/src/validator.dart';

15 import '../../lib/src/validator/sdk_constraint.dart';

16 import '../descriptor.dart' as d;

17 import '../test_pub.dart';

18 import 'utils.dart';

19

20 Validator sdkConstraint(Entrypoint entrypoint) =>

21 new SdkConstraintValidator(entrypoint);

22

23 main() {

24 initConfig();

25

26 group('should consider a package valid if it', () {

27 integration('has no SDK constraint', () {

28 d.validPackage.create();

29 expectNoValidationError(sdkConstraint);

30 });

31

32 integration('has an SDK constraint without ^', () {

33 d.dir(appPath, [

34 d.libPubspec("test_pkg", "1.0.0", sdk: ">=1.8.0 <2.0.0")

35 ]).create();

36 expectNoValidationError(sdkConstraint);

37 });

38 });

39

40 test("should consider a package invalid if it has an SDK constraint with "

41 "^", () {

42 d.dir(appPath, [

43 d.libPubspec("test_pkg", "1.0.0", sdk: "^1.8.0")

44 ]).create();

45 expect(schedulePackageValidation(sdkConstraint),

46 completion(pairOf(anyElement(contains('">=1.8.0 <2.0.0"')), isEmpty)));

47 });

48 }

OLD	NEW