Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

Issue 1165463010: [Android] Log exceptions thrown by newly converted DeviceUtils calls in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py
diff --git a/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py
index 73e126ea5cb4929dc257da60c9b8e0f71b88f124..34bc476214b147d68383247b0284cb7701dec30c 100644
--- a/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py
+++ b/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import logging
import re
import tempfile
@@ -38,7 +39,12 @@ class V8Profiler(profiler.Profiler):
# On Android pull the output file to the host.
if self._platform_backend.GetOSName() == 'android':
host_output_file = '%s.log' % self._output_path
- self._browser_backend.adb.device().PullFile(output_file, host_output_file)
+ try:
+ self._browser_backend.adb.device().PullFile(
+ output_file, host_output_file)
+ except:
+ logging.exception('New exception caused by DeviceUtils conversion')
+ raise
# Clean the device
self._browser_backend.adb.device().RunShellCommand('rm %s' % output_file)
output_file = host_output_file
« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698