Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

Issue 1165463010: [Android] Log exceptions thrown by newly converted DeviceUtils calls in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
index f0982e6bf8d53fd5e2c34f76d7cd012c8867bb18..cbc888783ffb57120e3bc1f17b3365a0462f6d12 100644
--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py
@@ -128,7 +128,11 @@ Try rerunning this script under sudo or setting
self._output_file)
if self._is_android:
device = self._browser_backend.adb.device()
- device.PullFile(self._device_output_file, self._output_file)
+ try:
+ device.PullFile(self._device_output_file, self._output_file)
+ except:
+ logging.exception('New exception caused by DeviceUtils conversion')
+ raise
required_libs = \
android_profiling_helper.GetRequiredLibrariesForPerfProfile(
self._output_file)

Powered by Google App Engine
This is Rietveld 408576698