tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py - Issue 1165463010: [Android] Log exceptions thrown by newly converted DeviceUtils calls in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

Issue 1165463010: [Android] Log exceptions thrown by newly converted DeviceUtils calls in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

index 92abae1801677ba26906a9616ae9b1c1bd281141..d00629c914585f0be81d614f18bf54b8098d3ace 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

@@ -43,9 +43,13 @@ class DS2784PowerMonitor(sysfs_power_monitor.SysfsPowerMonitor):

def CanMonitorPower(self):

if not self._HasFuelGauge():

return False

- if self._device_battery.GetCharging():

- logging.warning("Can't monitor power usage since device is charging.")

- return False

+ try:

+ if self._device_battery.GetCharging():

+ logging.warning("Can't monitor power usage since device is charging.")

+ return False

+ except:

+ logging.exception('New exception caused by DeviceUtils conversion')

+ raise

return True

def StartMonitoringPower(self, browser):