src/compiler/ast-graph-builder.cc - Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index b648495fdfd5d13cabefadec159ff16e442e07d2..d84cca6487ac1768ef004da119ced941be7e9133 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -1696,7 +1696,6 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {

Node* closure = GetFunctionClosure();

// Create node to deep-copy the literal boilerplate.

- expr->BuildConstantProperties(isolate());

Node* literals_array =

BuildLoadObjectField(closure, JSFunction::kLiteralsOffset);

Node* literal_index = jsgraph()->Constant(expr->literal_index());

« no previous file with comments | « src/ast-numbering.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »