Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 __ Push(x10); 1622 __ Push(x10);
1623 } else { 1623 } else {
1624 VisitForStackValue(expression); 1624 VisitForStackValue(expression);
1625 } 1625 }
1626 } 1626 }
1627 1627
1628 1628
1629 void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) { 1629 void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
1630 Comment cmnt(masm_, "[ ObjectLiteral"); 1630 Comment cmnt(masm_, "[ ObjectLiteral");
1631 1631
1632 expr->BuildConstantProperties(isolate());
1633 Handle<FixedArray> constant_properties = expr->constant_properties(); 1632 Handle<FixedArray> constant_properties = expr->constant_properties();
1634 __ Ldr(x3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 1633 __ Ldr(x3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1635 __ Ldr(x3, FieldMemOperand(x3, JSFunction::kLiteralsOffset)); 1634 __ Ldr(x3, FieldMemOperand(x3, JSFunction::kLiteralsOffset));
1636 __ Mov(x2, Smi::FromInt(expr->literal_index())); 1635 __ Mov(x2, Smi::FromInt(expr->literal_index()));
1637 __ Mov(x1, Operand(constant_properties)); 1636 __ Mov(x1, Operand(constant_properties));
1638 int flags = expr->ComputeFlags(); 1637 int flags = expr->ComputeFlags();
1639 __ Mov(x0, Smi::FromInt(flags)); 1638 __ Mov(x0, Smi::FromInt(flags));
1640 if (MustCreateObjectLiteralWithRuntime(expr)) { 1639 if (MustCreateObjectLiteralWithRuntime(expr)) {
1641 __ Push(x3, x2, x1, x0); 1640 __ Push(x3, x2, x1, x0);
1642 __ CallRuntime(Runtime::kCreateObjectLiteral, 4); 1641 __ CallRuntime(Runtime::kCreateObjectLiteral, 4);
(...skipping 3895 matching lines...) Expand 10 before | Expand all | Expand 10 after
5538 } 5537 }
5539 5538
5540 return INTERRUPT; 5539 return INTERRUPT;
5541 } 5540 }
5542 5541
5543 5542
5544 } // namespace internal 5543 } // namespace internal
5545 } // namespace v8 5544 } // namespace v8
5546 5545
5547 #endif // V8_TARGET_ARCH_ARM64 5546 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698