Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1165463007: Build ObjectLiteral constant properties in the numbering phase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1649 __ push(r1); 1649 __ push(r1);
1650 } else { 1650 } else {
1651 VisitForStackValue(expression); 1651 VisitForStackValue(expression);
1652 } 1652 }
1653 } 1653 }
1654 1654
1655 1655
1656 void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) { 1656 void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
1657 Comment cmnt(masm_, "[ ObjectLiteral"); 1657 Comment cmnt(masm_, "[ ObjectLiteral");
1658 1658
1659 expr->BuildConstantProperties(isolate());
1660 Handle<FixedArray> constant_properties = expr->constant_properties(); 1659 Handle<FixedArray> constant_properties = expr->constant_properties();
1661 __ ldr(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 1660 __ ldr(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
1662 __ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset)); 1661 __ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset));
1663 __ mov(r2, Operand(Smi::FromInt(expr->literal_index()))); 1662 __ mov(r2, Operand(Smi::FromInt(expr->literal_index())));
1664 __ mov(r1, Operand(constant_properties)); 1663 __ mov(r1, Operand(constant_properties));
1665 int flags = expr->ComputeFlags(); 1664 int flags = expr->ComputeFlags();
1666 __ mov(r0, Operand(Smi::FromInt(flags))); 1665 __ mov(r0, Operand(Smi::FromInt(flags)));
1667 if (MustCreateObjectLiteralWithRuntime(expr)) { 1666 if (MustCreateObjectLiteralWithRuntime(expr)) {
1668 __ Push(r3, r2, r1, r0); 1667 __ Push(r3, r2, r1, r0);
1669 __ CallRuntime(Runtime::kCreateObjectLiteral, 4); 1668 __ CallRuntime(Runtime::kCreateObjectLiteral, 4);
(...skipping 3904 matching lines...) Expand 10 before | Expand all | Expand 10 after
5574 DCHECK(interrupt_address == 5573 DCHECK(interrupt_address ==
5575 isolate->builtins()->OsrAfterStackCheck()->entry()); 5574 isolate->builtins()->OsrAfterStackCheck()->entry());
5576 return OSR_AFTER_STACK_CHECK; 5575 return OSR_AFTER_STACK_CHECK;
5577 } 5576 }
5578 5577
5579 5578
5580 } // namespace internal 5579 } // namespace internal
5581 } // namespace v8 5580 } // namespace v8
5582 5581
5583 #endif // V8_TARGET_ARCH_ARM 5582 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698