src/gpu/gl/builders/GrGLProgramBuilder.cpp - Issue 1165463005: Begin tracking driver info in GrGLContextInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLProgramBuilder.cpp

Issue 1165463005: Begin tracking driver info in GrGLContextInfo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLProgramBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLProgramBuilder.cpp b/src/gpu/gl/builders/GrGLProgramBuilder.cpp

index 1478279fe26afd6ca30a69ba0060fe3d6f49d6fd..1e6251ba66b007b4d5ba9efdb3c5f809373626f9 100644

--- a/src/gpu/gl/builders/GrGLProgramBuilder.cpp

+++ b/src/gpu/gl/builders/GrGLProgramBuilder.cpp

@@ -429,7 +429,7 @@ GrGLProgram* GrGLProgramBuilder::finalize() {

GL_CALL(LinkProgram(programID));

// Calling GetProgramiv is expensive in Chromium. Assume success in release builds.

- bool checkLinked = !fGpu->ctxInfo().isChromium();

+ bool checkLinked = kChromium_GrGLDriver != fGpu->ctxInfo().driver();

#ifdef SK_DEBUG

checkLinked = true;

#endif

« no previous file with comments | « src/gpu/gl/GrGLUtil.cpp ('k') | src/gpu/gl/builders/GrGLShaderStringBuilder.cpp » ('j') | no next file with comments »