Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1165463002: Make RenderParagraph mutable, and make it fit the new RenderNode protocols (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make RenderParagraph mutable, and make it fit the new RenderNode protocols R=abarth@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1243cf8442b8595b37ad9796750b8f8891c851d2

Patch Set 1 #

Patch Set 2 : merge in with adam's patch #

Patch Set 3 : merge upstream #

Patch Set 4 : git rebase -i #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -93 lines) Patch
M sky/examples/raw/render_paragraph.dart View 1 2 3 3 chunks +16 lines, -13 lines 0 comments Download
M sky/examples/raw/sector-layout.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A sky/examples/raw/simple_render_tree.dart View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 1 2 3 10 chunks +65 lines, -62 lines 0 comments Download
M sky/tests/raw/render_box.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M sky/tests/raw/render_flex.dart View 1 2 3 2 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
LGTM but you probably want eric to review
5 years, 6 months ago (2015-05-28 21:28:21 UTC) #2
eseidel
lgtm
5 years, 6 months ago (2015-05-28 21:35:31 UTC) #4
Hixie
5 years, 6 months ago (2015-05-28 22:19:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
1243cf8442b8595b37ad9796750b8f8891c851d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698