Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1165453009: [grokdump] Update v8heapconst.py (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[grokdump] Update v8heapconst.py R=jochen@chromium.org BUG= Committed: https://crrev.com/1c56723d1bea06e193beb74bc80c3e418060c6e0 Cr-Commit-Position: refs/heads/master@{#28843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -170 lines) Patch
M tools/v8heapconst.py View 4 chunks +170 lines, -170 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-08 14:46:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-08 14:49:23 UTC) #2
jochen (gone - plz use gerrit)
thank you
5 years, 6 months ago (2015-06-08 14:49:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165453009/1
5 years, 6 months ago (2015-06-08 14:51:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 18:16:02 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:16:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c56723d1bea06e193beb74bc80c3e418060c6e0
Cr-Commit-Position: refs/heads/master@{#28843}

Powered by Google App Engine
This is Rietveld 408576698