Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(84)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1165453007: Reland "DevTools: extract common inspector bindigns code into InspectorWrapper" (Closed)

Created:
4 years, 10 months ago by yurys
Modified:
4 years, 10 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland "DevTools: extract common inspector bindigns code into InspectorWrapper" This CL relands f35316229ae02ef512dee9c8aab9578c6ece2f13 (Oilpan: fix build after r196583.)and 08a9fc8c50d1df0e5364356ba513b75de50f8475 (DevTools: extract common inspector bindigns code into InspectorWrapper ) which were reverted in 14ccb0425b9deda0b575a12aa7e6592d4a6866d7 due to browser test failure which should be fixed by https://src.chromium.org/viewvc/blink?view=rev&revision=196742. BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -173 lines) Patch
M Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/bindings/core/v8/inspector/InspectorWrapper.h View 1 chunk +102 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/inspector/InspectorWrapper.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8InjectedScriptHost.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp View 17 chunks +28 lines, -85 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.cpp View 3 chunks +17 lines, -78 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165453007/1
4 years, 10 months ago (2015-06-08 13:24:03 UTC) #3
sergeyv
lgtm
4 years, 10 months ago (2015-06-08 13:45:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-08 15:35:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165453007/1
4 years, 10 months ago (2015-06-09 08:00:08 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 08:03:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196743

Powered by Google App Engine
This is Rietveld 408576698