Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools/json_schema_compiler/test/any_unittest.cc

Issue 116543010: Remove the Value class names from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/any_unittest.cc
diff --git a/tools/json_schema_compiler/test/any_unittest.cc b/tools/json_schema_compiler/test/any_unittest.cc
index 81fd6814e0bef11b578ea76a2174696d3ab4a928..7e3215f08f3f3b4c686096bfd067c76dc701feb9 100644
--- a/tools/json_schema_compiler/test/any_unittest.cc
+++ b/tools/json_schema_compiler/test/any_unittest.cc
@@ -10,33 +10,35 @@ using namespace test::api::any;
TEST(JsonSchemaCompilerAnyTest, AnyTypePopulate) {
{
AnyType any_type;
- scoped_ptr<DictionaryValue> any_type_value(new DictionaryValue());
+ scoped_ptr<base::DictionaryValue> any_type_value(
+ new base::DictionaryValue());
any_type_value->SetString("any", "value");
EXPECT_TRUE(AnyType::Populate(*any_type_value, &any_type));
- scoped_ptr<Value> any_type_to_value(any_type.ToValue());
+ scoped_ptr<base::Value> any_type_to_value(any_type.ToValue());
EXPECT_TRUE(any_type_value->Equals(any_type_to_value.get()));
}
{
AnyType any_type;
- scoped_ptr<DictionaryValue> any_type_value(new DictionaryValue());
+ scoped_ptr<base::DictionaryValue> any_type_value(
+ new base::DictionaryValue());
any_type_value->SetInteger("any", 5);
EXPECT_TRUE(AnyType::Populate(*any_type_value, &any_type));
- scoped_ptr<Value> any_type_to_value(any_type.ToValue());
+ scoped_ptr<base::Value> any_type_to_value(any_type.ToValue());
EXPECT_TRUE(any_type_value->Equals(any_type_to_value.get()));
}
}
TEST(JsonSchemaCompilerAnyTest, OptionalAnyParamsCreate) {
{
- scoped_ptr<ListValue> params_value(new ListValue());
+ scoped_ptr<base::ListValue> params_value(new base::ListValue());
scoped_ptr<OptionalAny::Params> params(
OptionalAny::Params::Create(*params_value));
EXPECT_TRUE(params.get());
EXPECT_FALSE(params->any_name.get());
}
{
- scoped_ptr<ListValue> params_value(new ListValue());
- scoped_ptr<Value> param(Value::CreateStringValue("asdf"));
+ scoped_ptr<base::ListValue> params_value(new base::ListValue());
+ scoped_ptr<base::Value> param(base::Value::CreateStringValue("asdf"));
params_value->Append(param->DeepCopy());
scoped_ptr<OptionalAny::Params> params(
OptionalAny::Params::Create(*params_value));
@@ -45,8 +47,8 @@ TEST(JsonSchemaCompilerAnyTest, OptionalAnyParamsCreate) {
EXPECT_TRUE(params->any_name->Equals(param.get()));
}
{
- scoped_ptr<ListValue> params_value(new ListValue());
- scoped_ptr<Value> param(Value::CreateBooleanValue(true));
+ scoped_ptr<base::ListValue> params_value(new base::ListValue());
+ scoped_ptr<base::Value> param(base::Value::CreateBooleanValue(true));
params_value->Append(param->DeepCopy());
scoped_ptr<OptionalAny::Params> params(
OptionalAny::Params::Create(*params_value));
« no previous file with comments | « tools/json_schema_compiler/test/additional_properties_unittest.cc ('k') | tools/json_schema_compiler/test/arrays_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698