Chromium Code Reviews

Issue 1165393005: Add helper for computing outset for 'outline' (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add helper for computing outset for 'outline' De-duplicates code from InlinePainter and SVGLayoutSupport. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196880

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+15 lines, -20 lines)
M Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +3 lines, -14 lines 0 comments
M Source/core/paint/InlinePainter.cpp View 1 chunk +1 line, -6 lines 0 comments
M Source/core/style/ComputedStyle.h View 1 chunk +1 line, -0 lines 0 comments
M Source/core/style/ComputedStyle.cpp View 2 chunks +10 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
fs
5 years, 6 months ago (2015-06-10 10:18:35 UTC) #2
pdr.
dedupecodes++ LGTM
5 years, 6 months ago (2015-06-10 17:19:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165393005/1
5 years, 6 months ago (2015-06-10 17:19:44 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:23:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196880

Powered by Google App Engine