Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1165363003: Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Blink) (Closed)

Created:
5 years, 6 months ago by jungkees
Modified:
5 years, 6 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Blink) Implement ServiceWorkerContainer.getReistrations() method as per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#navigator-service-worker-getRegistrations Companion CL (Chromium): https://codereview.chromium.org/1146913004/ Companion CL (Blink layout tests): https://codereview.chromium.org/1168393002/ Companion CL (Previous review): https://codereview.chromium.org/1143293003/ BUG=478382 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196843

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add method getRegistrations to global-interface-listing-expected.txt files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 3 chunks +29 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 2 chunks +23 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerProvider.h View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
jungkees
5 years, 6 months ago (2015-06-09 09:05:55 UTC) #3
jungkees
I made this previous CL a 3-sided patch with the blink layout test apart: https://codereview.chromium.org/1143293003/ ...
5 years, 6 months ago (2015-06-09 09:07:50 UTC) #4
falken
lgtm As suggested in the previous review, I made a chromestatus dashboard entry https://www.chromestatus.com/features/6734239512920064
5 years, 6 months ago (2015-06-10 03:38:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165363003/20001
5 years, 6 months ago (2015-06-10 03:58:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34992)
5 years, 6 months ago (2015-06-10 04:03:50 UTC) #9
tkent
lgtm
5 years, 6 months ago (2015-06-10 04:28:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165363003/20001
5 years, 6 months ago (2015-06-10 04:29:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65861)
5 years, 6 months ago (2015-06-10 05:40:17 UTC) #14
jungkees
It seems like 'method getRegistrations' should be added in webexposed/global-interface-listing.html and virtual/stable/webexposed/global-interface-listing.html. Can I add ...
5 years, 6 months ago (2015-06-10 06:14:26 UTC) #15
jungkees
Ah I mean 'webexposed/global-interface-listing-expected.txt' and 'virtual/stable/webexposed/global-interface-listing-expected.txt'.
5 years, 6 months ago (2015-06-10 06:16:54 UTC) #16
falken
On 2015/06/10 06:14:26, jungkees wrote: > It seems like 'method getRegistrations' should be added in ...
5 years, 6 months ago (2015-06-10 06:17:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165363003/60001
5 years, 6 months ago (2015-06-10 06:45:20 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 07:44:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196843

Powered by Google App Engine
This is Rietveld 408576698