Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9486)

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
index 7a7575c1977487ba4b9d357a6d2bf2e7e0db32b3..deb120682b5cbb6a246fafc882a5965b648b7991 100644
--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
@@ -20,6 +20,10 @@ namespace policy {
class ConsumerManagementService;
}
+namespace user_manager {
+class UserID;
+}
+
namespace chromeos {
class SigninScreenHandler;
@@ -146,10 +150,10 @@ class GaiaScreenHandler : public BaseScreenHandler {
bool using_saml);
// Fill GAIA user name.
- void PopulateEmail(const std::string& user_id);
+ void PopulateEmail(const std::string& email);
// Mark user as having password changed:
- void PasswordChangedFor(const std::string& user_id);
+ void PasswordChangedFor(const user_manager::UserID& user_id);
// Kick off cookie / local storage cleanup.
void StartClearingCookies(const base::Closure& on_clear_callback);
@@ -160,7 +164,7 @@ class GaiaScreenHandler : public BaseScreenHandler {
void OnDnsCleared();
// Show sign-in screen for the given credentials.
- virtual void ShowSigninScreenForCreds(const std::string& username,
+ virtual void ShowSigninScreenForCreds(const user_manager::UserID& user_id,
const std::string& password);
// Attempts login for test.
void SubmitLoginFormForTest();
@@ -220,7 +224,7 @@ class GaiaScreenHandler : public BaseScreenHandler {
std::string populated_email_;
// Emails of the users, whose passwords have recently been changed.
- std::set<std::string> password_changed_for_;
+ std::set<user_manager::UserID> password_changed_for_;
// True if dns cache cleanup is done.
bool dns_cleared_;

Powered by Google App Engine
This is Rietveld 408576698