Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: components/policy/core/browser/browser_policy_connector.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/browser_policy_connector.cc
diff --git a/components/policy/core/browser/browser_policy_connector.cc b/components/policy/core/browser/browser_policy_connector.cc
index c4768783fc381282b55d9973f13c28b7813e283e..ac6ba892ff68d653984cd1eae092cac563c62ad4 100644
--- a/components/policy/core/browser/browser_policy_connector.cc
+++ b/components/policy/core/browser/browser_policy_connector.cc
@@ -24,6 +24,7 @@
#include "components/policy/core/common/policy_service_impl.h"
#include "components/policy/core/common/policy_statistics_collector.h"
#include "components/policy/core/common/policy_switches.h"
+#include "components/user_manager/user_id.h"
#include "google_apis/gaia/gaia_auth_util.h"
#include "net/url_request/url_request_context_getter.h"
#include "policy/policy_constants.h"
@@ -214,16 +215,17 @@ void BrowserPolicyConnector::SetPolicyProviderForTesting(
}
// static
-bool BrowserPolicyConnector::IsNonEnterpriseUser(const std::string& username) {
- if (username.empty() || username.find('@') == std::string::npos) {
- // An empty username means incognito user in case of ChromiumOS and
+bool BrowserPolicyConnector::IsNonEnterpriseUser(const user_manager::UserID& user_id) {
+ const std::string& email = user_id.GetUserEmail();
+ if (email.empty() || email.find('@') == std::string::npos) {
+ // An empty email means incognito user in case of ChromiumOS and
// no logged-in user in case of Chromium (SigninService). Many tests use
// nonsense email addresses (e.g. 'test') so treat those as non-enterprise
// users.
return true;
}
const base::string16 domain = base::UTF8ToUTF16(
- gaia::ExtractDomainName(gaia::CanonicalizeEmail(username)));
+ gaia::ExtractDomainName(gaia::CanonicalizeEmail(email)));
for (size_t i = 0; i < arraysize(kNonManagedDomainPatterns); i++) {
base::string16 pattern = base::WideToUTF16(kNonManagedDomainPatterns[i]);
if (MatchDomain(domain, pattern, i))

Powered by Google App Engine
This is Rietveld 408576698