chrome/browser/chromeos/login/signin_screen_controller.h - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin_screen_controller.h

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signin/auth_sync_observer.cc ('K') | « chrome/browser/chromeos/login/signin/oauth2_login_manager.cc ('k') | chrome/browser/chromeos/login/signin_screen_controller.cc » ('j') | chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin_screen_controller.h

diff --git a/chrome/browser/chromeos/login/signin_screen_controller.h b/chrome/browser/chromeos/login/signin_screen_controller.h

index 893efc66cbdbd3f405b58621d1bd49e3b52be7aa..9301047bddfb3017155bfba886057370e3efdf73 100644

--- a/chrome/browser/chromeos/login/signin_screen_controller.h

+++ b/chrome/browser/chromeos/login/signin_screen_controller.h

@@ -46,15 +46,15 @@ class SignInScreenController : public user_manager::RemoveUserDelegate,

const user_manager::UserList& GetUsers();

// Runs OAauth token validity check.

- void CheckUserStatus(const std::string& user_id);

+ void CheckUserStatus(const user_manager::UserID& user_id);

// Query to remove user with specified id.

// TODO(antrim): move to user selection screen handler.

- void RemoveUser(const std::string& user_id);

+ void RemoveUser(const user_manager::UserID& user_id);

// user_manager::RemoveUserDelegate implementation:

- void OnBeforeUserRemoved(const std::string& username) override;

- void OnUserRemoved(const std::string& username) override;

+ void OnBeforeUserRemoved(const user_manager::UserID& user_id) override;

+ void OnUserRemoved(const user_manager::UserID& user_id) override;

// content::NotificationObserver implementation.

void Observe(int type,