chrome/browser/signin/signin_error_notifier_ash.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_error_notifier_ash.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_window.cc ('K') | « chrome/browser/signin/fake_profile_oauth2_token_service.h ('k') | chrome/browser/supervised_user/child_accounts/child_account_service.cc » ('j') | components/user_manager/user_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_error_notifier_ash.cc

diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc

index d3045606c04af051d9834dcbb79400d2a3c26a02..a87c1ba0cf5417ae8da37251c0e431abc39d8e31 100644

--- a/chrome/browser/signin/signin_error_notifier_ash.cc

+++ b/chrome/browser/signin/signin_error_notifier_ash.cc

@@ -26,6 +26,7 @@

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

+#include "components/user_manager/user_id.h"

#include "grit/theme_resources.h"

#include "third_party/WebKit/public/web/WebTextDirection.h"

#include "ui/base/l10n/l10n_util.h"

@@ -175,7 +176,7 @@ void SigninErrorNotifier::OnErrorChanged() {

kProfileSigninNotificationId);

// Set |profile_id| for multi-user notification blocker.

- notifier_id.profile_id = multi_user_util::GetUserIDFromProfile(profile_);

+ notifier_id.profile_id = multi_user_util::GetUserIDFromProfile(profile_).GetUserEmail();

Notification notification(

message_center::NOTIFICATION_TYPE_SIMPLE,