chrome/browser/chromeos/drive/file_system.h - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system.h

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('K') | « chrome/browser/chromeos/drive/fake_file_system.cc ('k') | chrome/browser/chromeos/drive/file_system.cc » ('j') | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system.h

diff --git a/chrome/browser/chromeos/drive/file_system.h b/chrome/browser/chromeos/drive/file_system.h

index 8ff6a633e96b2991ae72944312b6c84cefeef9c0..0172cb09361400c8d31df6b830ba6ed46d7960e4 100644

--- a/chrome/browser/chromeos/drive/file_system.h

+++ b/chrome/browser/chromeos/drive/file_system.h

@@ -147,7 +147,7 @@ class FileSystem : public FileSystemInterface,

void MarkCacheFileAsUnmounted(const base::FilePath& cache_file_path,

const FileOperationCallback& callback) override;

void AddPermission(const base::FilePath& drive_file_path,

- const std::string& email,

+ const user_manager::UserID& email,

google_apis::drive::PermissionRole role,

const FileOperationCallback& callback) override;

void SetProperty(const base::FilePath& drive_file_path,

@@ -231,7 +231,7 @@ class FileSystem : public FileSystemInterface,

const GURL& share_url);

// Part of AddPermission.

void AddPermissionAfterGetResourceEntry(

- const std::string& email,

+ const user_manager::UserID& email,

google_apis::drive::PermissionRole role,

const FileOperationCallback& callback,

ResourceEntry* entry,