chrome/browser/chromeos/login/screens/error_screen.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/error_screen.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/existing_user_controller.cc ('K') | « chrome/browser/chromeos/login/screens/error_screen.h ('k') | chrome/browser/chromeos/login/screens/user_image_screen.cc » ('j') | chrome/browser/chromeos/login/screens/user_selection_screen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/error_screen.cc

diff --git a/chrome/browser/chromeos/login/screens/error_screen.cc b/chrome/browser/chromeos/login/screens/error_screen.cc

index 35018c1229b8c738c5230a65e8b65f5e608dcfb3..5a3a883849d6c2a9bb2a423b191340158f40ab8a 100644

--- a/chrome/browser/chromeos/login/screens/error_screen.cc

+++ b/chrome/browser/chromeos/login/screens/error_screen.cc

@@ -240,7 +240,7 @@ void ErrorScreen::OnPasswordChangeDetected() {

LOG(FATAL);

}

-void ErrorScreen::WhiteListCheckFailed(const std::string& email) {

+void ErrorScreen::WhiteListCheckFailed(const user_manager::UserID& user_id) {

LOG(FATAL);

}

@@ -248,7 +248,7 @@ void ErrorScreen::PolicyLoadFailed() {

LOG(FATAL);

}

-void ErrorScreen::OnOnlineChecked(const std::string& username, bool success) {

+void ErrorScreen::OnOnlineChecked(const user_manager::UserID& user_id, bool success) {

LOG(FATAL);

}