chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_window.cc ('K') | « chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.h ('k') | chrome/browser/supervised_user/legacy/supervised_user_sync_service.h » ('j') | components/user_manager/user_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc

diff --git a/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc b/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc

index 2a73e386e4b3f6be1bdb5cf00a39014654909f05..a4fc6152b1ebf309f2a841258224ac6ebb2a97e7 100644

--- a/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc

+++ b/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_stub.cc

@@ -7,11 +7,12 @@

#include "base/bind.h"

#include "base/memory/scoped_ptr.h"

#include "base/strings/utf_string_conversions.h"

+#include "components/user_manager/user_id.h"

#include "google_apis/gaia/gaia_urls.h"

#include "google_apis/gaia/google_service_auth_error.h"

SupervisedUserRegistrationUtilityStub::SupervisedUserRegistrationUtilityStub()

- : register_was_called_(false) {

+ : register_was_called_(false), supervised_user_id_(std::string(), std::string()) {

}

SupervisedUserRegistrationUtilityStub::

@@ -19,7 +20,7 @@ SupervisedUserRegistrationUtilityStub::

}

void SupervisedUserRegistrationUtilityStub::Register(

- const std::string& supervised_user_id,

+ const user_manager::UserID& supervised_user_id,

const SupervisedUserRegistrationInfo& info,

const RegistrationCallback& callback) {

DCHECK(!register_was_called_);