chrome/browser/chromeos/policy/device_local_account_policy_store.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc ('K') | « chrome/browser/chromeos/policy/device_local_account_policy_service.cc ('k') | chrome/browser/chromeos/policy/device_status_collector.cc » ('j') | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

index a56b1b098e8f94e4997885394f21a33b196e3286..74f3772af9ec2f544fef3ff7b77d6414bcab2187 100644

--- a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

@@ -150,7 +150,7 @@ void DeviceLocalAccountPolicyStore::Validate(

scoped_ptr<UserCloudPolicyValidator> validator(

UserCloudPolicyValidator::Create(policy_response.Pass(),

background_task_runner()));

- validator->ValidateUsername(account_id_, false);

+ validator->ValidateUsername(user_manager::UserID::FromUserEmail(account_id_), false);

validator->ValidatePolicyType(dm_protocol::kChromePublicAccountPolicyType);

// The timestamp is verified when storing a new policy downloaded from the

// server but not when loading a cached policy from disk.