chrome/browser/ui/browser_navigator.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_window.cc ('K') | « chrome/browser/ui/browser_finder.cc ('k') | chrome/browser/ui/startup/startup_browser_creator.cc » ('j') | components/user_manager/user_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 8c10fe0ae0a4b7f9d1293ce50e02af1540530f7a..e41148748872f6b1af4c2f42dde587f5e77092f3 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -29,6 +29,7 @@

#include "chrome/browser/ui/tab_helpers.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/url_constants.h"

+#include "components/user_manager/user_id.h"

#include "content/public/browser/browser_url_handler.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_service.h"

@@ -540,7 +541,7 @@ void Navigate(NavigateParams* params) {

if (manager) {

aura::Window* src_window = source_browser->window()->GetNativeWindow();

aura::Window* new_window = params->browser->window()->GetNativeWindow();

- const std::string& src_user =

+ const user_manager::UserID& src_user =

manager->GetUserPresentingWindow(src_window);

if (src_user != manager->GetUserPresentingWindow(new_window)) {

// Once the window gets presented, it should be shown on the same