chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc - Issue 1165323004: We should use UserID object to identify users instead of username.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc

Issue 1165323004: We should use UserID object to identify users instead of username. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_window.cc ('K') | « chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h ('k') | chrome/browser/ui/app_list/app_list_service_impl.cc » ('j') | components/user_manager/user_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc b/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc

index a7bf05bbeeb4a0cb4208ee3fcd6d506cd305f8a7..53a87d9165ee88ecd1e36ba477ca75e69b9978d1 100644

--- a/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc

+++ b/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc

@@ -423,7 +423,7 @@ google_apis::CancelCallback DriveServiceOnWorker::UninstallApp(

google_apis::CancelCallback DriveServiceOnWorker::AddPermission(

const std::string& resource_id,

- const std::string& email,

+ const user_manager::UserID& email,

google_apis::drive::PermissionRole role,

const google_apis::EntryActionCallback& callback) {

NOTREACHED();