We should use UserID object to identify users instead of username.

chrome/browser/signin/easy_unlock_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/easy_unlock_service.h"
 
 #include "apps/app_lifetime_monitor.h"
 #include "apps/app_lifetime_monitor_factory.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/signin/easy_unlock_service_observer.h"
 #include "chrome/browser/signin/proximity_auth_facade.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/proximity_auth/ble/proximity_auth_ble_system.h"
 #include "components/proximity_auth/screenlock_bridge.h"
 #include "components/proximity_auth/switches.h"
 #include "components/user_manager/user.h"
+#include "components/user_manager/user_id.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h"
 #include "chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.h"
 #include "chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.h"
 #include "chrome/browser/chromeos/login/session/user_session_manager.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ skipping 234 matching lines @@
 void EasyUnlockService::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(prefs::kEasyUnlockDeviceId, std::string());
   registry->RegisterDictionaryPref(prefs::kEasyUnlockHardlockState);
   registry->RegisterDictionaryPref(prefs::kEasyUnlockLocalStateUserPrefs);
 #if defined(OS_CHROMEOS)
   EasyUnlockTpmKeyManager::RegisterLocalStatePrefs(registry);
 #endif
 }
 
 // static
-void EasyUnlockService::ResetLocalStateForUser(const std::string& user_id) {
+void EasyUnlockService::ResetLocalStateForUser(const user_manager::UserID& user_id) {
   DCHECK(!user_id.empty());
 
   PrefService* local_state = GetLocalState();
   if (!local_state)
     return;
 
   DictionaryPrefUpdate update(local_state, prefs::kEasyUnlockHardlockState);
-  update->RemoveWithoutPathExpansion(user_id, NULL);
+  update->RemoveWithoutPathExpansion(user_id.GetUserEmail(), NULL);
 
 #if defined(OS_CHROMEOS)
   EasyUnlockTpmKeyManager::ResetLocalStateForUser(user_id);
 #endif
 }
 
 // static
 EasyUnlockService::UserSettings EasyUnlockService::GetUserSettings(
-    const std::string& user_id) {
+    const user_manager::UserID& user_id) {
   DCHECK(!user_id.empty());
   UserSettings user_settings;
 
   PrefService* local_state = GetLocalState();
   if (!local_state)
     return user_settings;
 
   const base::DictionaryValue* all_user_prefs_dict =
       local_state->GetDictionary(prefs::kEasyUnlockLocalStateUserPrefs);
   if (!all_user_prefs_dict)
     return user_settings;
 
   const base::DictionaryValue* user_prefs_dict;
-  if (!all_user_prefs_dict->GetDictionaryWithoutPathExpansion(user_id,
+  if (!all_user_prefs_dict->GetDictionaryWithoutPathExpansion(user_id.GetUserEmail(),
                                                               &user_prefs_dict))
     return user_settings;
 
   user_prefs_dict->GetBooleanWithoutPathExpansion(
       prefs::kEasyUnlockProximityRequired,
       &user_settings.require_close_proximity);
 
   return user_settings;
 }
 
@@ skipping 47 matching lines @@
   const base::ListValue* devices = GetRemoteDevices();
   return devices && !devices->empty();
 }
 
 void EasyUnlockService::OpenSetupApp() {
   app_manager_->LaunchSetup();
 }
 
 void EasyUnlockService::SetHardlockState(
     EasyUnlockScreenlockStateHandler::HardlockState state) {
-  const std::string user_id = GetUserEmail();
+  const user_manager::UserID user_id = GetUserID();
   if (user_id.empty())
     return;
 
   if (state == GetHardlockState())
     return;
 
   SetHardlockStateForUser(user_id, state);
 }
 
 EasyUnlockScreenlockStateHandler::HardlockState
 EasyUnlockService::GetHardlockState() const {
   EasyUnlockScreenlockStateHandler::HardlockState state;
   if (GetPersistedHardlockState(&state))
     return state;
 
   return EasyUnlockScreenlockStateHandler::NO_HARDLOCK;
 }
 
 bool EasyUnlockService::GetPersistedHardlockState(
     EasyUnlockScreenlockStateHandler::HardlockState* state) const {
-  std::string user_id = GetUserEmail();
+  const user_manager::UserID user_id = GetUserID();
   if (user_id.empty())
     return false;
 
   PrefService* local_state = GetLocalState();
   if (!local_state)
     return false;
 
   const base::DictionaryValue* dict =
       local_state->GetDictionary(prefs::kEasyUnlockHardlockState);
   int state_int;
-  if (dict && dict->GetIntegerWithoutPathExpansion(user_id, &state_int)) {
+  if (dict && dict->GetIntegerWithoutPathExpansion(user_id.GetUserEmail(), &state_int)) {
     *state =
         static_cast<EasyUnlockScreenlockStateHandler::HardlockState>(state_int);
     return true;
   }
 
   return false;
 }
 
 void EasyUnlockService::ShowInitialUserState() {
   if (!GetScreenlockStateHandler())
@@ skipping 11 matching lines @@
     screenlock_state_handler_->MaybeShowHardlockUI();
   }
 }
 
 EasyUnlockScreenlockStateHandler*
     EasyUnlockService::GetScreenlockStateHandler() {
   if (!IsAllowed())
     return NULL;
   if (!screenlock_state_handler_) {
     screenlock_state_handler_.reset(new EasyUnlockScreenlockStateHandler(
-        GetUserEmail(), GetHardlockState(), GetScreenlockBridgeInstance()));
+        GetUserID(), GetHardlockState(), GetScreenlockBridgeInstance()));
   }
   return screenlock_state_handler_.get();
 }
 
 bool EasyUnlockService::UpdateScreenlockState(ScreenlockState state) {
   EasyUnlockScreenlockStateHandler* handler = GetScreenlockStateHandler();
   if (!handler)
     return false;
 
   handler->ChangeState(state);
 
   if (state == ScreenlockState::AUTHENTICATED) {
 #if defined(OS_CHROMEOS)
     if (power_monitor_)
       power_monitor_->RecordStartUpTime();
 #endif
   } else if (auth_attempt_.get()) {
     // Clean up existing auth attempt if we can no longer authenticate the
     // remote device.
     auth_attempt_.reset();
 
     if (!handler->InStateValidOnRemoteAuthFailure())
-      HandleAuthFailure(GetUserEmail());
+      HandleAuthFailure(GetUserID());
   }
 
   FOR_EACH_OBSERVER(
       EasyUnlockServiceObserver, observers_, OnScreenlockStateChanged(state));
   return true;
 }
 
 ScreenlockState EasyUnlockService::GetScreenlockState() {
   EasyUnlockScreenlockStateHandler* handler = GetScreenlockStateHandler();
   if (!handler)
     return ScreenlockState::INACTIVE;
 
   return handler->state();
 }
 
-void EasyUnlockService::AttemptAuth(const std::string& user_id) {
+void EasyUnlockService::AttemptAuth(const user_manager::UserID& user_id) {
   AttemptAuth(user_id, AttemptAuthCallback());
 }
 
-void EasyUnlockService::AttemptAuth(const std::string& user_id,
+void EasyUnlockService::AttemptAuth(const user_manager::UserID& user_id,
                                     const AttemptAuthCallback& callback) {
   const EasyUnlockAuthAttempt::Type auth_attempt_type =
       GetType() == TYPE_REGULAR ? EasyUnlockAuthAttempt::TYPE_UNLOCK
                                 : EasyUnlockAuthAttempt::TYPE_SIGNIN;
-  const std::string user_email = GetUserEmail();
-  if (user_email.empty()) {
+  const user_manager::UserID current_user_id = GetUserID();
+  if (current_user_id.empty()) {
     LOG(ERROR) << "Empty user email. Refresh token might go bad.";
     if (!callback.is_null()) {
       const bool kFailure = false;
       callback.Run(auth_attempt_type, kFailure, user_id, std::string(),
                    std::string());
     }
     return;
   }
 
-  CHECK_EQ(GetUserEmail(), user_id);
+  CHECK_EQ(GetUserID(), user_id);
 
   auth_attempt_.reset(new EasyUnlockAuthAttempt(app_manager_.get(), user_id,
                                                 auth_attempt_type, callback));
   if (!auth_attempt_->Start())
     auth_attempt_.reset();
 }
 
 void EasyUnlockService::FinalizeUnlock(bool success) {
   if (!auth_attempt_.get())
     return;
 
   this->OnWillFinalizeUnlock(success);
-  auth_attempt_->FinalizeUnlock(GetUserEmail(), success);
+  auth_attempt_->FinalizeUnlock(GetUserID(), success);
   auth_attempt_.reset();
   // TODO(isherman): If observing screen unlock events, is there a race
   // condition in terms of reading the service's state vs. the app setting the
   // state?
 
   // Make sure that the lock screen is updated on failure.
   if (!success) {
     RecordEasyUnlockScreenUnlockEvent(EASY_UNLOCK_FAILURE);
-    HandleAuthFailure(GetUserEmail());
+    HandleAuthFailure(GetUserID());
   }
 }
 
 void EasyUnlockService::FinalizeSignin(const std::string& key) {
   if (!auth_attempt_.get())
     return;
   std::string wrapped_secret = GetWrappedSecret();
   if (!wrapped_secret.empty())
-    auth_attempt_->FinalizeSignin(GetUserEmail(), wrapped_secret, key);
+    auth_attempt_->FinalizeSignin(GetUserID(), wrapped_secret, key);
   auth_attempt_.reset();
 
   // Processing empty key is equivalent to auth cancellation. In this case the
   // signin request will not actually be processed by login stack, so the lock
   // screen state should be set from here.
   if (key.empty())
-    HandleAuthFailure(GetUserEmail());
+    HandleAuthFailure(GetUserID());
 }
 
-void EasyUnlockService::HandleAuthFailure(const std::string& user_id) {
-  if (user_id != GetUserEmail())
+void EasyUnlockService::HandleAuthFailure(const user_manager::UserID& user_id) {
+  if (user_id != GetUserID())
     return;
 
   if (!screenlock_state_handler_.get())
     return;
 
   screenlock_state_handler_->SetHardlockState(
       EasyUnlockScreenlockStateHandler::LOGIN_FAILED);
 }
 
 void EasyUnlockService::CheckCryptohomeKeysAndMaybeHardlock() {
 #if defined(OS_CHROMEOS)
-  std::string user_id = GetUserEmail();
+  const user_manager::UserID user_id = GetUserID();
   if (user_id.empty())
     return;
 
   const base::ListValue* device_list = GetRemoteDevices();
   std::set<std::string> paired_devices;
   if (device_list) {
     chromeos::EasyUnlockDeviceKeyDataList parsed_paired;
     chromeos::EasyUnlockKeyManager::RemoteDeviceListToDeviceDataList(
         *device_list, &parsed_paired);
     for (const auto& device_key_data : parsed_paired)
@@ skipping 106 matching lines @@
 #endif
     }
   }
 }
 
 void EasyUnlockService::DisableAppWithoutResettingScreenlockState() {
   app_manager_->DisableAppIfLoaded();
 }
 
 void EasyUnlockService::NotifyUserUpdated() {
-  std::string user_id = GetUserEmail();
+  const user_manager::UserID user_id = GetUserID();
   if (user_id.empty())
     return;
 
   // Notify the easy unlock app that the user info changed.
   bool logged_in = GetType() == TYPE_REGULAR;
   bool data_ready = logged_in || GetRemoteDevices() != NULL;
   app_manager_->SendUserUpdatedEvent(user_id, logged_in, data_ready);
 }
 
 void EasyUnlockService::NotifyTurnOffOperationStatusChanged() {
@@ skipping 39 matching lines @@
         bttype = BT_NORMAL;
       }
 #endif
     }
     UMA_HISTOGRAM_ENUMERATION(
       "EasyUnlock.BluetoothAvailability", bttype, BT_MAX_TYPE);
   }
 }
 
 void EasyUnlockService::SetHardlockStateForUser(
-      const std::string& user_id,
+      const user_manager::UserID& user_id,
       EasyUnlockScreenlockStateHandler::HardlockState state) {
   DCHECK(!user_id.empty());
 
   PrefService* local_state = GetLocalState();
   if (!local_state)
     return;
 
   DictionaryPrefUpdate update(local_state, prefs::kEasyUnlockHardlockState);
-  update->SetIntegerWithoutPathExpansion(user_id, static_cast<int>(state));
+  update->SetIntegerWithoutPathExpansion(user_id.GetUserEmail(), static_cast<int>(state));
 
-  if (GetUserEmail() == user_id)
+  if (GetUserID() == user_id)
     SetScreenlockHardlockedState(state);
 }
 
 EasyUnlockAuthEvent EasyUnlockService::GetPasswordAuthEvent() const {
   DCHECK(IsEnabled());
 
   if (GetHardlockState() != EasyUnlockScreenlockStateHandler::NO_HARDLOCK) {
     switch (GetHardlockState()) {
       case EasyUnlockScreenlockStateHandler::NO_HARDLOCK:
         NOTREACHED();
@@ skipping 39 matching lines @@
         return PASSWORD_ENTRY_WITH_AUTHENTICATED_PHONE;
     }
   }
 
   NOTREACHED();
   return EASY_UNLOCK_AUTH_EVENT_COUNT;
 }
 
 #if defined(OS_CHROMEOS)
 void EasyUnlockService::OnCryptohomeKeysFetchedForChecking(
-    const std::string& user_id,
+    const user_manager::UserID& user_id,
     const std::set<std::string> paired_devices,
     bool success,
     const chromeos::EasyUnlockDeviceKeyDataList& key_data_list) {
   DCHECK(!user_id.empty() && !paired_devices.empty());
 
   if (!success) {
     SetHardlockStateForUser(user_id,
                             EasyUnlockScreenlockStateHandler::NO_PAIRING);
     return;
   }
@@ skipping 13 matching lines @@
 }
 #endif
 
 void EasyUnlockService::PrepareForSuspend() {
   app_manager_->DisableAppIfLoaded();
   if (screenlock_state_handler_ && screenlock_state_handler_->IsActive())
     UpdateScreenlockState(ScreenlockState::BLUETOOTH_CONNECTING);
 }
 
 void EasyUnlockService::EnsureTpmKeyPresentIfNeeded() {
-  if (tpm_key_checked_ || GetType() != TYPE_REGULAR || GetUserEmail().empty() ||
+  if (tpm_key_checked_ || GetType() != TYPE_REGULAR || GetUserID().empty() ||
       GetHardlockState() == EasyUnlockScreenlockStateHandler::NO_PAIRING) {
     return;
   }
 
 #if defined(OS_CHROMEOS)
   // If this is called before the session is started, the chances are Chrome
   // is restarting in order to apply user flags. Don't check TPM keys in this
   // case.
   if (!user_manager::UserManager::Get() ||
       !user_manager::UserManager::Get()->IsSessionStarted())
     return;
 
   // TODO(tbarzic): Set check_private_key only if previous sign-in attempt
   // failed.
   EasyUnlockTpmKeyManagerFactory::GetInstance()->Get(profile_)
       ->PrepareTpmKey(true /* check_private_key */,
                       base::Closure());
 #endif  // defined(OS_CHROMEOS)
 
   tpm_key_checked_ = true;
 }