remove covariant generics option

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ skipping 55 matching lines @@
       this.packagePaths: const <String>[], this.resources: const <String>[],
       this.inferFromOverrides: inferFromOverridesDefault,
       this.inferTransitively: inferTransitivelyDefault,
       this.onlyInferConstsAndFinalFields: onlyInferConstAndFinalFieldsDefault,
       this.entryPointFile: null, this.useImplicitHtml: false});
 }
 
 // TODO(vsm): Merge RulesOptions and TypeOptions
 /// Options used by our RestrictedRules.
 class RulesOptions extends TypeOptions {
-  /// Whether to use covariant generics
-  final bool covariantGenerics;
-
   /// Whether to infer types downwards from local context
   final bool inferDownwards;
   static const inferDownwardsDefault = true;
 
   /// Whether to inject casts between Dart assignable types.
   final bool relaxedCasts;
 
   /// Whether to use static types for code generation.
   final bool ignoreTypes;
 
-  RulesOptions({this.covariantGenerics: true,
-      this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true,
-      this.ignoreTypes: false});
+  RulesOptions({this.inferDownwards: inferDownwardsDefault,
+      this.relaxedCasts: true, this.ignoreTypes: false});
 }
 
 class JSCodeOptions {
   /// Whether to emit the source map files.
   final bool emitSourceMaps;
 
   JSCodeOptions({this.emitSourceMaps: true});
 }
 
 /// General options used by the dev compiler.
@@ skipping 41 matching lines @@
 
   /// Whether to enable hash-based caching of files.
   final bool enableHashing;
 
   /// Port used for the HTTP server when [serverMode] is on.
   final int port;
 
   /// Host name or address for HTTP server when [serverMode] is on.
   final String host;
 
-  /// Whether to use covariant generics
-  @override
-  final bool covariantGenerics;
-
   /// Whether to inject casts between Dart assignable types.
   @override
   final bool relaxedCasts;
 
   /// Whether to resolve 'package:' uris using the multi-package resolver.
   @override
   final bool useMultiPackage;
 
   /// Package root when resolving 'package:' urls the standard way.
   @override
@@ skipping 40 matching lines @@
   /// Location for runtime files, such as `dart_runtime.js`. By default this is
   /// inferred to be under `lib/runtime/` in the location of the `dev_compiler`
   /// package (if we can infer where that is located).
   final String runtimeDir;
 
   /// Custom URI mappings, such as "dart:foo" -> "path/to/foo.dart"
   final Map<String, String> customUrlMappings;
 
   CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
       this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
-      this.outputDir, this.useColors: true, this.covariantGenerics: true,
-      this.relaxedCasts: true, this.useMultiPackage: false,
-      this.packageRoot: 'packages/', this.packagePaths: const <String>[],
-      this.resources: const <String>[],
+      this.outputDir, this.useColors: true, this.relaxedCasts: true,
+      this.useMultiPackage: false, this.packageRoot: 'packages/',
+      this.packagePaths: const <String>[], this.resources: const <String>[],
       this.inferDownwards: RulesOptions.inferDownwardsDefault,
       this.inferFromOverrides: ResolverOptions.inferFromOverridesDefault,
       this.inferTransitively: ResolverOptions.inferTransitivelyDefault,
       this.onlyInferConstsAndFinalFields: ResolverOptions.onlyInferConstAndFinalFieldsDefault,
       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
       this.useMockSdk: false, this.dartSdkPath, this.logLevel: Level.SEVERE,
       this.emitSourceMaps: true, this.entryPointFile: null,
       this.serverMode: false, this.useImplicitHtml: false,
       this.enableHashing: false, this.host: 'localhost', this.port: 8080,
       this.runtimeDir, this.customUrlMappings: const {}});
@@ skipping 45 matching lines @@
 
   var entryPointFile = args.rest.length == 0 ? null : args.rest.first;
 
   return new CompilerOptions(
       checkSdk: args['sdk-check'],
       dumpInfo: dumpInfo,
       dumpInfoFile: args['dump-info-file'],
       forceCompile: args['force-compile'] || serverMode,
       ignoreTypes: args['ignore-types'],
       outputDir: outputDir,
-      covariantGenerics: args['covariant-generics'],
       relaxedCasts: args['relaxed-casts'],
       useColors: useColors,
       customUrlMappings: customUrlMappings,
       useMultiPackage: args['use-multi-package'],
       packageRoot: args['package-root'],
       packagePaths: args['package-paths'].split(','),
       resources: args['resources']
           .split(',')
           .where((s) => s.isNotEmpty)
           .toList(),
@@ skipping 16 matching lines @@
       port: int.parse(args['port']),
       runtimeDir: runtimeDir);
 }
 
 final ArgParser argParser = new ArgParser()
   // resolver/checker options
   ..addFlag('sdk-check',
       abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
   ..addFlag('mock-sdk',
       abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
-  ..addFlag('covariant-generics',
-      help: 'Use covariant generics', defaultsTo: true)
   ..addFlag('ignore-types',
       help: 'Ignore types during codegen', defaultsTo: false)
   ..addFlag('relaxed-casts',
       help: 'Cast between Dart assignable types', defaultsTo: true)
   ..addOption('nonnullable',
       abbr: 'n',
       help: 'Comma separated string of non-nullable types',
       defaultsTo: null)
   ..addFlag('infer-downwards',
       help: 'Infer types downwards from local context',
@@ skipping 100 matching lines @@
     // The pub-cache directory is two levels up, but we verify that the layout
     // looks correct.
     if (path.basename(dir) != 'dev_compiler') return null;
     dir = path.dirname(dir);
     if (path.basename(dir) != 'global_packages') return null;
     dir = path.dirname(dir);
     return path.join(dir, cacheDir, 'lib', 'runtime');
   }
   return null;
 }