Source/platform/fonts/mac/FontPlatformDataMac.mm - Issue 1165293003: Work around CGDataProvider premature release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/FontPlatformDataMac.mm

Issue 1165293003: Work around CGDataProvider premature release. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/mac/FontPlatformDataMac.mm

diff --git a/Source/platform/fonts/mac/FontPlatformDataMac.mm b/Source/platform/fonts/mac/FontPlatformDataMac.mm

index 54cee47cb10c957c9cabeb128b2fa9ec2a78d6b0..1eaa4767d02ab9f7ca962ec375ed06fa38c230dc 100644

--- a/Source/platform/fonts/mac/FontPlatformDataMac.mm

+++ b/Source/platform/fonts/mac/FontPlatformDataMac.mm

@@ -94,7 +94,7 @@ static PassRefPtr<SkTypeface> loadFromBrowserProcess(NSFont* nsFont, float textS

}

RetainPtr<CGFontRef> cgFont(AdoptCF, loadedCgFont);

RetainPtr<CTFontRef> ctFont(AdoptCF, CTFontCreateWithGraphicsFont(cgFont.get(), textSize, 0, cascadeToLastResortFontDescriptor()));

- PassRefPtr<SkTypeface> returnFont = adoptRef(SkCreateTypefaceFromCTFont(ctFont.get()));

+ PassRefPtr<SkTypeface> returnFont = adoptRef(SkCreateTypefaceFromCTFont(ctFont.get(), cgFont.get()));

if (!returnFont.get())

// TODO crbug.com/461279: Make this appear in the inspector console?

« no previous file with comments | « no previous file | no next file » | no next file with comments »