Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1165293003: Work around CGDataProvider premature release. (Closed)

Created:
4 years, 10 months ago by bungeman-chromium
Modified:
4 years, 10 months ago
Reviewers:
Robert Sesek, eae
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Work around CGDataProvider premature release. Allow Skia to keep the original CGFont alive for the lifetime of the SkTypeface. BUG=chromium:413332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/fonts/mac/FontPlatformDataMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bungeman-chromium
This CL is based on the observation that sometimes a CTFont created from a CGFont ...
4 years, 10 months ago (2015-06-08 21:32:15 UTC) #2
bungeman-chromium
At the moment this is waiting on the Skia roll at https://codereview.chromium.org/1169863004/ . Will start ...
4 years, 10 months ago (2015-06-08 21:34:16 UTC) #3
eae
LGTM
4 years, 10 months ago (2015-06-08 21:38:30 UTC) #4
Robert Sesek
LGTM, hopefully this works! (For reference, Skia change: https://codereview.chromium.org/1163573007/)
4 years, 10 months ago (2015-06-08 21:40:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165293003/1
4 years, 10 months ago (2015-06-09 14:20:41 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 15:25:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196774

Powered by Google App Engine
This is Rietveld 408576698