git_cl.py - Issue 1165293002: Add period below review URL when adding review URL footer to committed CLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1165293002: Add period below review URL when adding review URL footer to committed CLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 26f04fd8c8289ba838902f272f11346a7ef626c3..5ff11fc152c0d6e12e2124944ad8f152968001a5 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2394,7 +2394,9 @@ def SendUpstream(parser, args, cmd):

commit_desc = ChangeDescription(change_desc.description)

if cl.GetIssue():

- commit_desc.append_footer('Review URL: %s' % cl.GetIssueURL())

+ # Xcode won't linkify this URL unless there is a non-whitespace character

+ # after it. Add a period on a new line to circumvent this.

+ commit_desc.append_footer('Review URL: %s.' % cl.GetIssueURL())

if options.contributor:

commit_desc.append_footer('Patch from %s.' % options.contributor)

« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »