Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 116523005: Always show x-webkit-speech icon for ease of testing. (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Always show x-webkit-speech icon for ease of testing. Because of a behavior change of crbug.com/325496, we need to focus on an INPUT element, move mouse pointer on it, or style it so that it works as ever before clicking the x-webkit-speech icon. Without this CL, WebViewTest.SpeechRecognition will fail when https://codereview.chromium.org/100793006/ is laned. BUG=325496 TBR=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/speech/guest.html View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
Sorry for the TBR. I'd like to land https://codereview.chromium.org/100793006/ for M33 for consistency.
7 years ago (2013-12-16 23:12:59 UTC) #1
tkent
7 years ago (2013-12-16 23:13:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r241059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698